Jump to content

The Old Man

Premium
  • Content Count

    216
  • Joined

  • Last visited

  • Days Won

    4
Everything posted by The Old Man
 
 
  1. I forgot to the most important suggestion! Big pay rise for Pete! He's a star.
  2. This is a little worrying Sherri, because I remember you saying a couple of years ago that to better manage your time and improve things that you would be switching to focus on new themes, a new framework and maintaining only some of the better quality, wider appeal classics, because some of the old ones were getting dated in style and format. You also said you'd not be taking on any custom themes because they are time consuming. Please, because I've always loved IBTheme, give some thought to some suggestions (not intended as criticisms and I'm not claiming to be an expert): Perhaps get a few QA testers. Put out at least a release candidate of each theme, in time to get at least 2 weeks testing on a variety of real world devices, if only for those extra special seasonal themes. I frequently see issues with the Google fonts cropping up, the CSS specifies a certain style, but the font is never loaded, only Lato is, so the end result is a fallback to 1990's style traditional fonts like Verdana and Aria! You can also load more than one Google font in one request (line of code) which is faster. DNSPrefetch and Preloading is handy for image or code heavy themes like yours, because they preconnect resources and can load in the background before being called. Streamline that CSS! It is honestly so bloated, I bet you could probably save yourself quite a lot of time on editing, your themes would be lighter and faster loading as a result. For example, there are many repeated lines of outdated vendor specific css properties, originally needed for cross browser compatibility that you probably don't need anymore, because they have since become obsolete. Features like gradients and shadows are now well supported across browsers. There are 100's of entries containing 0px in your CSS code, but there's technically no such thing as zero pixels or 0 em. You could save all those extra characters by carefully doing a search and replace such as " 0px" with a space so you don't affect ones like 20px, 30px by accident and changing them to a just a 0, which would pass validation. Likewise, you often see 4 separate lines for each border, margin or padding, where you could replace the 4 lines with 1. Multiply that out and I bet you would save a lot of lines of code in a whole theme, multiply that by your total number of themes and look at the potential time and file size saving. More mobile friendly gets you a Google Pagespeed boost too! Perhaps you could create higher quality versions of some of the original artwork like the snowmen, elves etc, for retina and high DPI devices Like iPads and iPhones. I still use a standard size image for my logos but include a x2 (double size version) which is lovely, gorgeous and crisp on good tablets or 4K monitors. The extra handy settings for things like Snow in your latest templates is really good, it saves editing templates and is much more elegant, quick and tidy. Nice one!
  3. Thanks Pete, just PM'd you the remaining bugs in Christmas Noel, mostly fixed just a few preventing it from going live. I've abandoned the idea of White Christmas, it's still too buggy but to be honest isn't right for my site about a dark crime drama TV series. Here Comes Santa is too elfy and cute for my site also, so thanks for working so hard on Noel.
  4. Thanks Sherri. Actually I think Here Comes Santa isn't as nice as Noel. The weird thing is the layout is fine here. The version numbers are not matching which may have something to do with it. I tried White Christmas and there are certainly issues on the main index. (The image above shows the footer covered, but only the index, seems fine elsewhere.)
  5. Freshly installed and layout knackered. Aargh!
  6. I've now also removed the Here Comes Santa and Christmas Noel themes before they went live. They don't seem to work well on modern responsive, tablet devices like the iPad, yet I noticed Here Comes Santa is okay here, the layout isn't broken. The graphics are so blurry or over compressed, they look quite poor on high res devices. The normal 2 bar menu is for some reason reduced to one bar, which is way too cramped especially if you have the full suite, only by changing and rejigging my menus could I get it to stop breaking, because the themes remove the Secondary Nav Bar! Even then the breadcrumb area near Mark As Read and all the sidebar widgets kept overlapping the right green border or pushing the page over off screen. The traditional forum table layout wasn't as bad, but the grid layout was constantly broken. I tried every combination of sidebar on toggling widgets/mobile/responsive/fluid/percentage width possible without much success. Some of these issues were fixed here after reporting but the downloaded versions didn't include the fixes for some reason.
  7. I hate myself for posting this because I know how hard you work but your themes seriously need some QA checks before they get released. They come across as rushed. I waited until closer to Christmas to install some Xmas themes thinking if I leave it later, the bugs will have been found and fixed, but I just installed 2 of them (Here Comes Santa and Christmas Noel) and they are broken in terms of responsive layout, header image logo and background out of alignment, tiny unreadable font size, widget font size too large breaking the widgets, club forums shown on main index have tiny images etc. I just validated your main page out of interest and it has over 130 errors, and validation can't finish. https://validator.w3.org/nu/?useragent=Validator.nu%2FLV+http%3A%2F%2Fvalidator.w3.org%2Fservices&acceptlanguage=&doc=https%3A%2F%2Fwww.ibtheme.com%2F
  8. What happened to your fixes, @Pete T? I downloaded Here Comes Santa and Christmas Noel, and the headers are both broken on an iPad. I returned here and they are broken here again? Also in both themes, spotted this CSS error... @media screen and (max-width: 979px) { #forum_wrapper1{ background: #transparent; margin-top: 0px !important; margin-left: 0px !important; /* Border Left Width */ margin-right: 0px !important; /* Border Right Width */ margin-bottom: 0px !important; max-width: 100% !important; } }
  9. You fixed it good! Thank you. Yes it might be intentional (the bg color) because the editor is a similar light grey colour, but just in case it was overlooked. The forum index, using an iPad and grid view, all of the forum titles are still on top of the pile of presents.
  10. Grid view: possibly default showing around file uploads:
  11. The header is broken too on iPad landscape.
  12. Thanks Pete, I don't know how you manage to fit everything into your day.
  13. Thank heavens you're back to help again Pete! It's a shame to read this, but it's sadly true. I have some feedback as well if that's okay. Often, lots of the themes have really nice artwork and immediate visual impact, but when you look closer or start using them for a few days on your site, that's when the annoying issues really come to light that really should have been spotted before the theme got released. You ideally need to do some more QA testing! I don't use the majority of themes because they are so much different from the dark crime drama 'theme' of my main community, so I rely on the seasonal Themes. However I just don't understand why so many of the themes continue to have so many issues, it seems that often they are the same ones, time and time again or that are broken in the same areas on several themes. Remember last year I made that list of issues that routinely crop up in several themes? I thought if you are using a framework, they could be fixed more easily. The broken category footers... ... are a regular thing, but how can they be missed in so many themes, especially after we've already reported them? Here's a fresh one though! I'd spent quite some time trying to figure out why one of my members kept complaining she was missing new content, it was no longer showing unread items in bold in her Activity Stream. It turned out to be the CSS in recent Halloween themes. In the default theme I was using, new unread items appear in bold, but not in the Halloween theme. The themes are also often absolutely huge. Hallows Eve and Happy Halloween despite looking great were over 12MB page size on my site and when you look at them, they are bloated with unnecessary vendor CSS code for old and outdated browsers. with HTML 5 and CSS3, things like box-shadows and linear gradients are supported as standard on modern, safe browsers. Take a look at this example: background: -moz-linear-gradient(top, #454300 0%, #252200 100%) !important; background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#454300), color-stop(100%,#252200)) !important; background: -webkit-linear-gradient(top, #454300 0%,#252200 100%) !important; background: -o-linear-gradient(top, #454300 0%,#252200 100%) !important; background: -ms-linear-gradient(top, #454300 0%,#252200 100%) !important; background: linear-gradient(to bottom, #454300 0%,#252200 100%) !important; -moz-box-shadow: inset 1px 1px 0px 0px rgba(93,88,0,0.3) !important; -webkit-box-shadow: inset 1px 1px 0px 0px rgba(93,88,0,0.3) !important; box-shadow: inset 1px 1px 0px 0px rgba(93,88,0,0.3) !important; border: 1px solid #000 !important; } #elProfileStats { background: #dbc19d !important; background: -moz-linear-gradient(top, #f8dfbc 0%, #866b44 100%) !important; background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#f8dfbc), color-stop(100%,#866b44)) !important; background: -webkit-linear-gradient(top, #f8dfbc 0%,#866b44 100%) !important; background: -o-linear-gradient(top, #f8dfbc 0%,#866b44 100%) !important; background: -ms-linear-gradient(top, #f8dfbc 0%,#866b44 100%) !important; background: linear-gradient(to bottom, #f8dfbc 0%,#866b44 100%) !important; border: 1px solid #000 !important; color: #000 !important; text-shadow: 0px 0px 1px rgba(0,0,0,0.2) !important; } a:hover { color: #eb821b !important; text-shadow: 0px 1px 1px #000 !important; text-decoration: none; transition: all 0.35s ease-in-out !important; -webkit-transition: all 0.35s ease-in-out !important; -moz-transition: all 0.35s ease-in-out !important; -o-transition: all 0.35s ease-in-out !important; -ms-transition: all 0.35s ease-in-out !important; } I don't think the CSS has to have the !important tag on every line either. It just causes more problems and more more bloat. I've also found in Halloween theme that it is specifies to use Ringbearer font, yet the 2 Google Fonts imported are different, Taviraj and Triong. Also, for a performance improvement, these two separate requests when both fonts could be requested at the same time in one request. /* Fonts */ @import 'https://fonts.googleapis.com/css?family=Taviraj'; @import 'https://fonts.googleapis.com/css?family=Trirong'; @font-face { font-family: 'ringbearermedium'; src: url({resource="ringm-webfont.eot" app="core" location="fonts"}); src: url({resource="ringm-webfont.eot?#iefix" app="core" location="fonts"}) format('embedded-opentype'), url({resource="ringm-webfont.woff2" app="core" location="fonts"}) format('woff2'), url({resource="ringm-webfont.woff" app="core" location="fonts"}) format('woff'), url({resource="ringm-webfont.ttf" app="core" location="fonts"}) format('truetype'), url({resource="ringm-webfont.svg#ringbearermedium" app="core" location="fonts"}) format('svg'); font-weight: normal; font-style: normal; } A couple of other bugbears are themes packaged with a logo saying IBSkin.com in the actual logo as would be correct on this website, but which means on every other site they are to be used it won't match the name of the clients actual site, and therefore must be edited with the .psd, which many don't have the knowledge, time or software to use. I also don't understand why your time is spent theming the AdminCP, it was a ridiculous idea on IPS's part in the first place. I don't think anyone logs in AdminCP to see a theme! Or stays for long enough to enjoy it! Usually there are only 1 or 2 people with Admin access! I just feel your valuable time and limited resources could be better utilised. After all themes are best when you have them showcased on the front end! I'm not sure why there are so many really obscure or outdated themes being re-released instead of getting the more modern, higher demand ones working better, and developing new themes? I'd love to see Sherri's artistic talent shine again in some new Christmas Themes this year, but hopefully less cartoony though! Thanks for reading!
  14. Just realised I posted these replies on Happy Halloween when I was actually referring to Hallow's Eve. Oops! In relation to Happy Halloween (Boo!) theme, my highlighted blog comment replies (replies to a blog comment) are showing with an ugly default white background.
  15. Thank @Pete T, when you say "template needs updating", does that mean it's something I need to do?
  16. Fixes the Subscriptions header font colour issue: Add this to your custom.css: /* Fixes black text on very dark background with matching orange pumpkin color on subscriptions page */ .ipsPageHeader h1 {color: #eb821b}
  17. Hallows Eve is probably my favourite theme ever, thank you so much! Spotted a few bugs here and on my own site installation. 1) I think this is site-wide security issue here as opposed to Hallows Eve theme, I can see the Promote buttons and seem to have permission content to Promote to your social media! Yikes! 2) When looking at my profile here and at my own site, I see a broken template message in relation to followers. Only on my own profile though from what I see here. [[Template core/front/profile/followers is throwing an error. This theme may be out of date. Run the support tool in the AdminCP to restore the default theme.]] 3) Found another just now after posting the above, code is invisible due to font colour, after inserting via the editor Code button popup. Also the pop up editor box is bright white. 4) Activity Stream pages, possibly too wide as they appear to be going out of view on the left. 5) Store Subscriptions inside the Commerce Store, the heading Subscriptions is black font colour, on a dark purple background. Also the boxes around each subscriptions package are missing their borders. 6) Chatbox (free) - Open the Chatbox emoji option and the text is black, almost impossible to see. Same here.
  18. Just FYI... https://invisioncommunity.com/4guides/themes-and-customizations/upgrading-themes-to-44-r320/
  19. Hi Pete, yes these were all fixed by you throughout this year, aside from the header image ones you are working on this weekend in the Christmas themes!
  20. Hi, I listed some of the issues I've reported to support through this last 12 months, in case they are useful to supplement your pre-release checklists. Hope it helps. Unthemed text background colour when pasting draft content from editor from one forum into another on Here comes Santa 2018. Default unthemed IPS colours showing in following areas: Unthemed areas in Calendar Reviews & Comments, Top and bottom of the pop-up Notifications list unthemed (when you click the bell icon) Chatbox Emoticon top and bottom bars unthemed Unthemed CSS code, quote and spoiler box CSS Difficult to see colours: Geode - Reputation Points in postbit (forum) colour were hard to read when member has more than 0 points. Misc Spring Fling, Ivy League and Simplicity Red and themes - main menu was overlapping some buttons preventing user from clicking on Unread Content or any breadcrumb links. Geode had a menu item glitch seemed to be a fixed CSS width too short for menu text If you scroll down the calendar, a floating white tool bar appears in default colours. I noticed in the CSS for Hallows Eve, there was a call for a png file at IBTheme.com which doesn't exist and causes a 404 on my site. .ipsApp select:not([multiple]) / select_dropdown.png When using grid layout there was some left over code causing double category footers to appear. Fixed by Pete on every theme. Nexa - iPad - Search box covering user menu. Halloween Grid layout was broken when using an iPad in landscape mode, the header is much shorter than the rest of the page, either with or without Chatbox enabled. Christmas Noel 2018 and Here Comes Santa header broken in iPad landscape mode (Pete fixing as I type!), but can't test White Christmas as not yet available in theme chooser menu.
 
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.