Jump to content
Michael Lachney

Broken Themes

Recommended Posts

 

Hi so i am back here as Admin trying to help where i can during my busy period but can ask what themes looking at ? and what broken so take a look.

Share this post


Link to post
Share on other sites
 
 
 
7 minutes ago, Pete T said:

Ok thanks reporting theme i will take look them and fix the issues that been reported.

Also on French Country theme, haven't look at the other themes the CHAT is transparent making it difficult to see chat messages.

 

chat2.PNG.45b7f6281f67680eff358b7e8b27201c.PNG

  • Like 1

Share this post


Link to post
Share on other sites
 
 

Thank heavens you're back to help again Pete!

On 11/4/2019 at 7:58 PM, Michael Lachney said:

However, there are still quite a few themes that are broken. Will these be fixed? 


It's a shame to read this, but it's sadly true. I have some feedback as well if that's okay.

Often, lots of the themes have really nice artwork and immediate visual impact, but when you look closer or start using them for a few days on your site, that's when the annoying issues really come to light that really should have been spotted before the theme got released. You ideally need to do some more QA testing!
 

I don't use the majority of themes because they are so much different from the dark crime drama 'theme' of my main community, so I rely on the seasonal Themes. However I just don't understand why so many of the themes continue to have so many issues, it seems that often they are the same ones, time and time again or that are broken in the same areas on several themes. Remember last year I made that list of issues that routinely crop up in several themes? I thought if you are using a framework, they could be fixed more easily.

The broken category footers...

F06EE48B-1AC6-42F1-90CA-AB88A07D1843.thumb.jpeg.8c2a6a02150c7e3096e662ee83e772cd.jpeg
 

 

... are a regular thing, but how can they be missed in so many themes, especially after we've already reported them?

Here's a fresh one though!
I'd spent quite some time trying to figure out why one of my members kept complaining she was missing new content, it was no longer showing unread items in bold in her Activity Stream. It turned out to be the CSS in recent Halloween themes. In the default theme I was using, new unread items appear in bold, but not in the Halloween theme.

The themes are also often absolutely huge. Hallows Eve and Happy Halloween despite looking great were over 12MB page size on my site and when you look at them, they are bloated with unnecessary vendor CSS code for old and outdated browsers. with HTML 5 and CSS3, things like box-shadows and linear gradients are supported as standard on modern, safe browsers.

Take a look at this example:

	background: -moz-linear-gradient(top, #454300 0%, #252200 100%) !important;
	background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#454300), color-stop(100%,#252200)) !important;
	background: -webkit-linear-gradient(top, #454300 0%,#252200 100%) !important;
	background: -o-linear-gradient(top, #454300 0%,#252200 100%) !important;
	background: -ms-linear-gradient(top, #454300 0%,#252200 100%) !important;
	background: linear-gradient(to bottom, #454300 0%,#252200 100%) !important;
	-moz-box-shadow: inset 1px 1px 0px 0px rgba(93,88,0,0.3) !important;
	-webkit-box-shadow: inset 1px 1px 0px 0px rgba(93,88,0,0.3) !important;
	box-shadow: inset 1px 1px 0px 0px rgba(93,88,0,0.3) !important;
	border: 1px solid #000 !important;
}
		
#elProfileStats {
	background: #dbc19d !important;
	background: -moz-linear-gradient(top, #f8dfbc 0%, #866b44 100%) !important;
	background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#f8dfbc), color-stop(100%,#866b44)) !important;
	background: -webkit-linear-gradient(top, #f8dfbc 0%,#866b44 100%) !important;
	background: -o-linear-gradient(top, #f8dfbc 0%,#866b44 100%) !important;
	background: -ms-linear-gradient(top, #f8dfbc 0%,#866b44 100%) !important;
	background: linear-gradient(to bottom, #f8dfbc 0%,#866b44 100%) !important;
	border: 1px solid #000 !important;
	color: #000 !important;
    text-shadow: 0px 0px 1px rgba(0,0,0,0.2) !important;
}		

a:hover {
	color: #eb821b !important;
	text-shadow: 0px 1px 1px #000 !important;
	text-decoration: none;
	transition: all 0.35s ease-in-out !important;
	-webkit-transition: all 0.35s ease-in-out !important;
	-moz-transition: all 0.35s ease-in-out !important;
	-o-transition: all 0.35s ease-in-out !important;
	-ms-transition: all 0.35s ease-in-out !important;
}

I don't think the CSS has to have the !important tag on every line either. It just causes more problems and more more bloat.

I've also found in Halloween theme that it is specifies to use Ringbearer font, yet the 2 Google Fonts imported are different, Taviraj and Triong.
 

Also, for a performance improvement, these two separate requests when both fonts could be requested at the same time in one request.

/* Fonts */

@import 'https://fonts.googleapis.com/css?family=Taviraj';
@import 'https://fonts.googleapis.com/css?family=Trirong';


@font-face {
	font-family: 'ringbearermedium';
	src: url({resource="ringm-webfont.eot" app="core" location="fonts"});
	src: url({resource="ringm-webfont.eot?#iefix" app="core" location="fonts"}) format('embedded-opentype'),
	url({resource="ringm-webfont.woff2" app="core" location="fonts"}) format('woff2'),
	url({resource="ringm-webfont.woff" app="core" location="fonts"}) format('woff'),
	url({resource="ringm-webfont.ttf" app="core" location="fonts"}) format('truetype'),
	url({resource="ringm-webfont.svg#ringbearermedium" app="core" location="fonts"}) format('svg');
	font-weight: normal;
	font-style: normal;
}

A couple of other bugbears are themes packaged with a logo saying IBSkin.com in the actual logo as would be correct on this website, but which means on every other site they are to be used it won't match the name of the clients actual site, and therefore must be edited with the .psd, which many don't have the knowledge, time or software to use.

I also don't understand why your time is spent theming the AdminCP, it was a ridiculous idea on IPS's part in the first place. I don't think anyone logs in AdminCP to see a theme! Or stays for long enough to enjoy it! Usually there are only 1 or 2 people with Admin access! I just feel your valuable time and limited resources could be better utilised. After all themes are best when you have them showcased on the front end!

I'm not sure why there are so many really obscure or outdated themes being re-released instead of getting the more modern, higher demand ones working better, and developing new themes?

I'd love to see Sherri's artistic talent shine again in some new Christmas Themes this year, but hopefully less cartoony though!
 

Thanks for reading!

  • Like 3

Share this post


Link to post
Share on other sites
 

Hi @The Old Man thank you for your feedback I do agree about QA testing maybe might trial this as personal I might look at theme once or twice but this mainly I get so busy, so only look issue when reported, as Css I feedback to Sherri on that, I am trying learn her new tricks (What this space).

  • Like 1

Share this post


Link to post
Share on other sites
 
 
3 hours ago, The Old Man said:

Thanks Pete, I don't know how you manage to fit everything into your day.

I no idea myself but i spend about 12 to 14 hours per day doing work just fit in my busy life then i spend time family in between that.

  • Haha 1

Share this post


Link to post
Share on other sites
 

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members
     
     

    No registered users viewing this page.

     
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.